Docker version#14
Conversation
|
Hi @piersoft, thanks for this contribution — Docker support is a great addition and the multi-stage build with non-root user is well done. A few things to address before merging: Language: The project uses English as its primary language. Could you translate Healthcheck (flagged by AI code review): The current healthcheck tries HEALTHCHECK --interval=30s --timeout=10s --start-period=15s --retries=3 \
CMD curl -sf -X POST http://localhost:${PORT}/mcp \
-H 'Content-Type: application/json' \
-d '{"jsonrpc":"2.0","method":"tools/list","id":1}' > /dev/null || exit 1Repo URL: Once these are fixed we're happy to merge. Thanks again! |
|
Thanks for the updates — language and URL are now good. Two remaining points: Dockerfile healthcheck: still using the broken
If your fork has local customizations, the cleanest way to stay aligned with upstream is: git remote add upstream https://github.com/ondata/ckan-mcp-server.git
git fetch upstream
git merge upstream/mainThis way you can keep your local changes (e.g. removed portals, custom config) in your fork, and when you want to open a PR toward Please revert |
|
Hi @piersoft, the new additions are interesting — an Ollama + React chat UI on top of the MCP server is a real-world use case worth showcasing. That said, files like This way the MCP server core stays clean, and the Ollama+chat stack lives as a self-contained example — a pattern used by many open source projects to show real integrations without polluting the main codebase. The One thing still pending: please revert If you reorganize along these lines, we're happy to merge the whole thing together. What do you think? |
|
Thank you so much @piersoft — One last thing: Once that's done, we're ready to merge. |
Description
Added Dockerfile and docker-compose.yml
Related Issue
Feature for enable installation with: docker compose up --build -d